-
Notifications
You must be signed in to change notification settings - Fork 67
chore: Fix dependency CI tests #3883
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📋 Review Summary
This pull request refactors the .github/workflows/dependency_compatibility_test.yaml workflow to ensure that the necessary modules are installed before the showcase server is set up. This change is logical and should resolve the dependency issues in the CI tests.
🔍 General Feedback
The change is well-structured and improves the reliability of the CI workflow. The updated comment also adds clarity to the purpose of the step. Overall, this is a good improvement.
|
There is a problem with the Gemini CLI PR review. Please check the action logs for details. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📋 Review Summary
This PR fixes a dependency issue in the CI workflow. The change is straightforward and looks correct.
🔍 General Feedback
- The change to move the installation step earlier in the workflow is logical.
- The updated comment provides better clarity.
|
|
``` Error: Unable to process file command 'env' successfully. Error: format '[ERROR] Non-resolvable import POM: The following artifacts could not be resolved: com.google.cloud:google-cloud-shared-dependencies:pom:3.51.1-SNAPSHOT (absent): Could not find artifact com.google.cloud:google-cloud-shared-dependencies:pom:3.51.1-SNAPSHOT @ com.google.cloud:gapic-showcase-parent:0.0.1-SNAPSHOT, /home/runner/work/sdk-platform-java/sdk-platform-java/java-showcase/pom.xml, line 32, column 19' ``` Complaining about not being able to retrieve shared-deps



Complaining about not being able to retrieve shared-deps